Error logging missing key data

Forum for questions and support relating to the 1.24.x releases only.
Locked
MrEvoMan
Posts: 55
Joined: Thu Apr 23, 2009 1:25 am

Error logging missing key data

Post by MrEvoMan »

I'm working on testing out the new 1.25.0, but I saw this problem in 1.24.x releases as well.

Some of the error logs don't list any indication as to which monitor/camera is having a problem. It makes troubleshooting very difficult. Here's a couple examples:

Aug 13 13:54:11 titan zmc[4490]: ERR [Unable to read content]
Aug 13 13:54:11 titan zmc[4490]: ERR [Unable to get response]
Aug 13 13:54:11 titan zma[4509]: ERR [Got unexpected memory map file size 6145280, expected 4609280]
Aug 13 13:54:01 titan zmc[3308]: INF [Got signal 15 (Terminated), exiting]
Aug 13 13:54:01 titan zmc[3308]: ERR [Select error: Interrupted system call]

I was looking through the code and see that the errors logged don't have any indications in them to list a name:

Error( "Connection dropped by remote end" );

Now, couldn't it just be re-worded to say something like:

Error( "%s: Connection dropped by remote end", name );

However, I'm not savvy enough to know how to "declare" the name in that scope.

Any suggestions on how to add this functionality? Think it could be something fixed/changed in the 1.25.0 release? It's really helpful to know which monitor/camera is having the problem!

Thanks!
MrEvoMan
Posts: 55
Joined: Thu Apr 23, 2009 1:25 am

Re: Error logging missing key data

Post by MrEvoMan »

No help here?
MrEvoMan
Posts: 55
Joined: Thu Apr 23, 2009 1:25 am

Re: Error logging missing key data

Post by MrEvoMan »

Someone has to know how to add a camera name to the error logging!
mastertheknife
Posts: 678
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: Error logging missing key data

Post by mastertheknife »

Error( "Monitor %d connection dropped by remote end", id );

mastertheknife :D
Kfir Itzhak.
User avatar
zoneminder
Site Admin
Posts: 5215
Joined: Wed Jul 09, 2003 2:07 pm
Location: Bristol, UK
Contact:

Re: Error logging missing key data

Post by zoneminder »

Something odd is going one as you should get the identity of the monitor in the string as per

Code: Select all

Aug 23 14:32:28 beast zmc_m216[19914]: ERR [Select error: Interrupted system call]
The _m216 indentifies the monitor. What is your distro?
Phil
Locked