Bugfix for Ncs370.pm

If you've made a patch to quick fix a bug or to add a new feature not yet in the main tree then post it here so others can try it out.
Post Reply
wileyc
Posts: 1
Joined: Sat Aug 20, 2011 6:51 am

Bugfix for Ncs370.pm

Post by wileyc »

Hi there,

There's a longstanding bug in the Ncs370.pm control module that, well, prevents the control from working. To wit, $cmd is never added to the HTTP POST request. I don't see how this could ever have worked as written ...

... ordinarily I'd attach a diff or post it inline, but the anti-spam software on this forum is disallowing all attempts to attach files ("extension not allowed") or place it inline ("post looks too spammy, remove external URLs").

The fix is to add "$req->content($cmd);" to the sendCmd subroutine between the "my $req ... " and "my $res ... " lines. I've also got a fix for diagonal movement, but that's more than a one-liner.

Hope this helps out someone else with an old camera.
Post Reply