ZM 1.25.0 Performance Patch - Completed

If you've made a patch to quick fix a bug or to add a new feature not yet in the main tree then post it here so others can try it out.
User avatar
dvarapala
Posts: 53
Joined: Sat Nov 06, 2010 2:30 pm

Re: ZM 1.24.4 Performance Patch - Completed

Post by dvarapala » Sun Mar 11, 2012 8:19 pm

mastertheknife wrote: xlib_shm relies on a specific shared memory layout, of which i changed and might change again in the future if new features are added.
Is it possible that these changes to the shared memory layout are the reason that zmtrigger.pl no longer works?

Image

mastertheknife
Posts: 679
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: ZM 1.25.0 Performance Patch - Completed

Post by mastertheknife » Sun Mar 11, 2012 9:10 pm

Thanks for reporting, I'll tackle this in the next few days.
Kfir Itzhak.

mastertheknife
Posts: 679
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: ZM 1.25.0 Performance Patch - Completed

Post by mastertheknife » Mon Mar 12, 2012 6:03 pm

Hi,

zmtrigger.pl is now working like expected.
The error was caused by me, in my changes to Memory.pm.in. I blindly copied code from another function in the file to another, not noticing a small difference. This broke shared memory writes from perl and is the reason zmtrigger.pl (and perhaps others) weren't working.
Please re-download the source, re-run configure(important), make and sudo make install:
http://github.com/mastertheknife/ZoneMi ... /perfpatch

This can be used to test zmtrigger.pl when in doubt:

Code: Select all

echo "<monitorID>|on+30|99|title|desc|showtext" > /dev/tcp/localhost/6802
mastertheknife
Kfir Itzhak.

beerygaz
Posts: 28
Joined: Wed Jul 08, 2009 9:43 am
Location: Johannesburg, South Africa

Re: ZM 1.25.0 Performance Patch - Completed

Post by beerygaz » Tue Mar 13, 2012 5:30 pm

Working like a charm Love your work, keep up the innovation.

User avatar
dvarapala
Posts: 53
Joined: Sat Nov 06, 2010 2:30 pm

Re: ZM 1.25.0 Performance Patch - Completed

Post by dvarapala » Tue Mar 13, 2012 7:01 pm

Yup, that did the trick - triggers are now working again. :D

christophe_y2k
Posts: 102
Joined: Mon Oct 12, 2009 8:47 am
Location: EUROPE-FRANCE-MANDELIEU

Re: ZM 1.25.0 Performance Patch - Completed

Post by christophe_y2k » Mon Mar 19, 2012 4:04 pm

Hello,

it's possible to have your patched version included in the latest svn version ?
or have another svn source ?

Thank you

mastertheknife
Posts: 679
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: ZM 1.25.0 Performance Patch - Completed

Post by mastertheknife » Mon Mar 19, 2012 6:41 pm

christophe_y2k wrote:it's possible to have your patched version included in the latest svn version ?
Not sure yet.
christophe_y2k wrote:or have another svn source ?
I have a git source: http://github.com/mastertheknife/ZoneMinder-kfir

mastertheknife
Kfir Itzhak.

User avatar
nightcrawler
Posts: 71
Joined: Fri Aug 12, 2011 9:54 am
Location: the netherlands

Re: ZM 1.25.0 Performance Patch - Completed

Post by nightcrawler » Mon Mar 19, 2012 9:43 pm

I want to thank you for your excellent work!
I run ZM 1.25 on an 1.65ghz P4 mobile with 2 analoge camera's on an cheap ebay card and the average cpu load has an performance increase of 25%!
And also the native BGR24 support is an great new feature!

But I got 2 minor issue's.

1) Your scripts has an install location for the HTdocs dan default. (var/www/zoneminder/htdocs) that's no problem but an new user have to be aware of that. (o fcourse is configurable at the ./configure command)

2) Can you update your GIT source with my updated NL_NL translation from this post? it got a lot of corrections for the dutch language.
Zoneminder @Ubuntu 11 server, ZM 1.25.0 , FFMPEG, 4 Analoge cameras, 1.6ghz P4mobile, 2GB ram, 60GB-HDD.
I also have an (homeseer) domotica system up-and-running with touchscreens,light controllers,weather forecast etc.

christophe_y2k
Posts: 102
Joined: Mon Oct 12, 2009 8:47 am
Location: EUROPE-FRANCE-MANDELIEU

Re: ZM 1.25.0 Performance Patch - Completed

Post by christophe_y2k » Wed Mar 21, 2012 2:20 pm

Hello, Master K. and thanks for the job and tips

On my gentoo64 have an issue with this error and no image ...
i precise that config works fine with the last official svn

Code: Select all

2012-03-21 15:04:01.197890	zmwatch	30939	ERR	Can't get shared memory id '7a6d0005', 5: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.197570	zmwatch	30939	ERR	Can't get shared memory id '7a6d0005', 5: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.197150	zmwatch	30939	ERR	Can't get shared memory id '7a6d0004', 4: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.196840	zmwatch	30939	ERR	Can't get shared memory id '7a6d0004', 4: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.196430	zmwatch	30939	ERR	Can't get shared memory id '7a6d0003', 3: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.196280	zmwatch	30939	ERR	Can't get shared memory id '7a6d0003', 3: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.195960	zmwatch	30939	ERR	Can't get shared memory id '7a6d0002', 2: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.195670	zmwatch	30939	ERR	Can't get shared memory id '7a6d0002', 2: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.195290	zmwatch	30939	ERR	Can't get shared memory id '7a6d0001', 1: Aucun fichier ou dossier de ce type	zmwatch.pl	
2012-03-21 15:04:01.194850	zmwatch	30939	ERR	Can't get shared memory id '7a6d0001', 1: Aucun fichier ou dossier de ce type	zmwatch.pl
Possible you can help me :

my method for installing

Code: Select all

# rm -R /usr/share/zoneminder2
# svn co https://github.com/mastertheknife/ZoneMinder-kfir/branches/perfpatch /usr/share/zoneminder2

Révision 2723 extraite.

# cd /usr/share/zoneminder2
#./configure --prefix=/usr --with-webhost=zoneminder --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --with-libarch=lib64 --with-mysql=/usr --with-ffmpeg=/usr --with-webdir=/var/www/zoneminder/htdocs --with-cgidir=/var/www/zoneminder/cgi-bin --with-webuser=apache --with-webgroup=apache --enable-debug=no --enable-crashtrace=no --enable-mmap=no ZM_DB_HOST=localhost ZM_DB_NAME=zm ZM_DB_USER=**** ZM_DB_PASS=**** CXXFLAGS=-D__STDC_CONSTANT_MACROS

# make
# make install
# make clean
# cd ..
# zmupdate.pl
# zmupdate.pl -f
after "zmupdate.pl -f" have an error message only once

any good idea???

christophe_y2k
Posts: 102
Joined: Mon Oct 12, 2009 8:47 am
Location: EUROPE-FRANCE-MANDELIEU

Re: ZM 1.25.0 Performance Patch - Completed

Post by christophe_y2k » Wed Mar 21, 2012 2:52 pm

[SOLVED]

after reading the top of the post .... the manual

i retry with

Code: Select all

# mysql --user=root -p mysql
Enter password: ****
# mysql> use zm
# mysql> ALTER TABLE `Monitors` ADD `Colours` TINYINT UNSIGNED NOT NULL DEFAULT '1' AFTER `Height`;
# quit;
before installing and now that working fine...

mastertheknife
Posts: 679
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: ZM 1.25.0 Performance Patch - Completed

Post by mastertheknife » Sun Mar 25, 2012 1:58 pm

nightcrawler wrote:I want to thank you for your excellent work!
I run ZM 1.25 on an 1.65ghz P4 mobile with 2 analoge camera's on an cheap ebay card and the average cpu load has an performance increase of 25%!
And also the native BGR24 support is an great new feature!

But I got 2 minor issue's.

1) Your scripts has an install location for the HTdocs dan default. (var/www/zoneminder/htdocs) that's no problem but an new user have to be aware of that. (o fcourse is configurable at the ./configure command)

2) Can you update your GIT source with my updated NL_NL translation from this post? it got a lot of corrections for the dutch language.
Hi,
Glad to hear :D

1) It was just an example.
2) I think something like this should be added to ZM's SVN repo instead, because my git is simply ZM SVN revision 3522 (latest) with my changes applied ontop of it.

mastertheknife
Kfir Itzhak.

christophe_y2k
Posts: 102
Joined: Mon Oct 12, 2009 8:47 am
Location: EUROPE-FRANCE-MANDELIEU

Re: ZM 1.25.0 Performance Patch - Completed

Post by christophe_y2k » Mon Mar 26, 2012 7:55 am

Hello Master K. , could you update your svn source because the latest official svn fix a bug with jpeg streaming when you do not use cambozola with latest firefox

version 3522 Le Vendredi 24 Novembre 2011 (Your older SVN source)
Version 3535 Le Lundi 12 Décenmbre 2011
Version 3578 Le Jeudi 29 décembre 2011
Version 3579 Le Samedi 31 décembre 2011
Version 3614 Le Mercredi 11 Janvier 2011
version 3639 Le Mercredi 25 Janvier 2011
version 3648 Le Mercredi 29 Février 2012
Version 3648 Le Lundi 26 Mars 2012 (Already the latest official SVN source)


Many thanks for the JOB

User avatar
nightcrawler
Posts: 71
Joined: Fri Aug 12, 2011 9:54 am
Location: the netherlands

Re: ZM 1.25.0 Performance Patch - Completed

Post by nightcrawler » Mon Mar 26, 2012 1:37 pm

mm the ZM config table is empty after an power distribution at my homegrid.. and this was also happening when I upgrade from the 1.25 distro to this performance patch GIT version. Does somebody know why this is happening? I can repair the table by loading the default settings from the initial create table&load script but that's not the way I should work!
Zoneminder @Ubuntu 11 server, ZM 1.25.0 , FFMPEG, 4 Analoge cameras, 1.6ghz P4mobile, 2GB ram, 60GB-HDD.
I also have an (homeseer) domotica system up-and-running with touchscreens,light controllers,weather forecast etc.

mastertheknife
Posts: 679
Joined: Wed Dec 16, 2009 4:32 pm
Location: Israel

Re: ZM 1.25.0 Performance Patch - Completed

Post by mastertheknife » Sun Apr 01, 2012 12:16 pm

christophe_y2k wrote:Hello Master K. , could you update your svn source because the latest official svn fix a bug with jpeg streaming when you do not use cambozola with latest firefox

version 3522 Le Vendredi 24 Novembre 2011 (Your older SVN source)
Version 3535 Le Lundi 12 Décenmbre 2011
Version 3578 Le Jeudi 29 décembre 2011
Version 3579 Le Samedi 31 décembre 2011
Version 3614 Le Mercredi 11 Janvier 2011
version 3639 Le Mercredi 25 Janvier 2011
version 3648 Le Mercredi 29 Février 2012
Version 3648 Le Lundi 26 Mars 2012 (Already the latest official SVN source)


Many thanks for the JOB
Hi,

The changes between 3648 and 3522 are not in the trunk. This means that for us, there is no difference between 3648 and 3522.

mastertheknife
Kfir Itzhak.

User avatar
nightcrawler
Posts: 71
Joined: Fri Aug 12, 2011 9:54 am
Location: the netherlands

Re: ZM 1.25.0 Performance Patch - Completed

Post by nightcrawler » Sun Apr 01, 2012 7:07 pm

nightcrawler wrote:mm the ZM config table is empty after an power distribution at my homegrid.. and this was also happening when I upgrade from the 1.25 distro to this performance patch GIT version. Does somebody know why this is happening? I can repair the table by loading the default settings from the initial create table&load script but that's not the way I should work!
So I've made and work around for it, an updated script from the zm_create.sql and made a post here with an how-to handle
Zoneminder @Ubuntu 11 server, ZM 1.25.0 , FFMPEG, 4 Analoge cameras, 1.6ghz P4mobile, 2GB ram, 60GB-HDD.
I also have an (homeseer) domotica system up-and-running with touchscreens,light controllers,weather forecast etc.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests