[REPOSTED PATCH] Fix "Incomplete read of frame image da

If you've made a patch to quick fix a bug or to add a new feature not yet in the main tree then post it here so others can try it out.
Post Reply
genanr
Posts: 9
Joined: Tue Apr 08, 2008 9:49 pm

[REPOSTED PATCH] Fix "Incomplete read of frame image da

Post by genanr » Wed Jan 27, 2010 7:57 pm

This patch adds a loop when reading from the frame image pipe. I was getting occasional "Incomplete" messages (in which case, the frame is dropped), even though the whole frame was sent to the pipe. The problem is that all the data was not available in the pipe for zmf when it read from the pipe. Adding the loop allows it to read the entire frame.

The patch was incorrectly posted the first time. I have since posted it to the wiki page here:

http://www.zoneminder.com/wiki/index.php/1.24.2_Patches

The patch seems to be working well for me, I hope it will help others too.

Andy
Last edited by genanr on Mon Feb 22, 2010 7:55 pm, edited 5 times in total.

User avatar
Cgroesser
Posts: 2
Joined: Tue Feb 09, 2010 8:40 pm
Location: Netherlands

How to use this patch

Post by Cgroesser » Fri Feb 12, 2010 8:19 pm

This patch looks good if its working. I like to use it but, because I get a lot of these errors, i dont no how to patch the original zmf.cpp file. Never worked with C and i'm not shure what the ! chars and so on mean.

curtishall
Posts: 440
Joined: Sat Sep 25, 2004 12:45 am
Location: Fulton, MO
Contact:

Re: How to use this patch

Post by curtishall » Fri Feb 12, 2010 8:51 pm

Cgroesser wrote:This patch looks good if its working. I like to use it but, because I get a lot of these errors, i dont no how to patch the original zmf.cpp file. Never worked with C and i'm not shure what the ! chars and so on mean.
!= is "does not equal" or "not equal to"
--
Curtis Hall
Bluecherry
www.bluecherrydvr.com
store.bluecherry.net

User avatar
Cgroesser
Posts: 2
Joined: Tue Feb 09, 2010 8:40 pm
Location: Netherlands

Trying to patch this

Post by Cgroesser » Sun Feb 14, 2010 8:26 pm

Oke I got the meaning of the ! chars. But whet I try to patch this on the original i got a warning like this:
patch: **** Premature `---' at line 17; check line numbers at line 4. I think this means there are some lines missing in the patch. Mayby something went wrong when cutting and paste this patch to this forum. Is there somebody who has done this with succes??
Chris

genanr
Posts: 9
Joined: Tue Apr 08, 2008 9:49 pm

Incompete frame patch repost

Post by genanr » Wed Feb 17, 2010 10:55 pm

Yeah, the posted patch was wrong. Leaving HTML on messed up the patch, even though it was in a code block. It will be posted once I get the thing to post correctly.

I put the patch on the ZoneMinder Wiki

Get it here:

http://www.zoneminder.com/wiki/index.php/1.24.2_Patches

Andy

User avatar
knight-of-ni
Posts: 2275
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Post by knight-of-ni » Fri Mar 05, 2010 12:54 am

Works like a champ on latest svn, revision 3033.

Thanks genanr!

netwrkr
Posts: 15
Joined: Tue Sep 09, 2008 2:56 pm

Re: [REPOSTED PATCH] Fix "Incomplete read of frame image da

Post by netwrkr » Wed Aug 31, 2011 6:28 pm

Works like a champ on 1.25.0. Any chance we can get this in future versions?

User avatar
knight-of-ni
Posts: 2275
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: [REPOSTED PATCH] Fix "Incomplete read of frame image da

Post by knight-of-ni » Tue Oct 04, 2011 1:20 pm

I recently upgraded to 1.25.0 and was surprised that this patch was not included in the source. Perhaps the author is not aware. I'll post a link to this thread as a feature request and see if we get a bite.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/

User avatar
knight-of-ni
Posts: 2275
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: [REPOSTED PATCH] Fix "Incomplete read of frame image da

Post by knight-of-ni » Tue Oct 04, 2011 1:34 pm

Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/

Post Reply

Who is online

Users browsing this forum: No registered users and 4 guests