Done! so how do I make it work.

[burger]

Followed the instructions from here: https://github.com/dlandon/zoneminder

The only change to the instructions I made was replacing the '0's with 1's for running assuming I want all the extras.
...

1- I tried rebooting but no luck.
2- I tried using the same sudo docker run -d --name="Zoneminder" \ and the rest but it tells me the container is already in use.
3- I also have no idea how to access it. When I tried ZM back in 2017 I just used localhost/zm in it displayed. I tried as the instructions 'https://<MyMachiesIP>:8443/zm but no luck.
4- If I do an 'ifconfig' it has added 'docker0:' but it's on a different Ip address, netmask and broadcast.
5- Do I / should I have installed lamp python php and mysql or such before hand. Does the docker need them?
100% novice so I have no idea.

With docker, you have to let the container start, and that can take maybe 1-5 minutes (depending on container complexity). If you interrupt the container before it finishes its startup, it will be in a broken state. At that point, you have to delete the container and start over.

To do so:
docker kill <containername> (stops running container)
docker rm -f <imagename> (deletes image - not container)
See also:
docker ps (list running containers)
docker images (list images)


For your docker run command, I would advise you look into docker-compose. That is easier to manage than the command line.

That is a start. You might want to get a book on docker. Adrian Mouat has a good intro book.

The docker does not require any other dependencies (LAMP). It should include everything, and run with a single command.

[burger]

For beginners, the easy way to install ZM is to use bbhunge's installation guides on the wiki, see
wiki.zoneminder.com/Debian
wiki.zoneminder.com/Ubuntu
(these guides are also linked from wiki.zoneminder.com/Contents)

Docker is not for beginners. It is often harder to setup, at first than just installing. This is due to the layer of abstraction that docker provides in configuration values and settings.

It has benefits down the road in administration, though. Think of it as an investment. At first you pay in more, then you hope for a return later on. Once you get docker working (which can admittedly take a while for simple things), then it is as easy as running a command, and certain things are future proof (such as dependencies and installation environments being supported for long term, distribution environments, etc.).