ES 6.0: Coming soon and breaking changes

[asker]

Folks, ES 6.0 will be out soon.
Please read https://medium.com/zmninja/es-6-0-and-l ... c91b5b7137

If you want, you can update to master and start preparing. Specifically, don't just upgrade and expect things to work. Please read the post above.

[Magic919]

The ride might be a bit bumpy, but it’s a great journey. Thanks for all your work on this.

[Magic919]

I presume some others have done the upgrade already. Did mine today.

Only thing of note is the config migration script doesn't discriminate, so all instances of the word 'models' will become 'detection_sequence', even if if it's the path on the filesystem. 'weights' and 'object_weights' will do the same and need some pruning. I also got duplicates cpu_max_* parts of the configs. It's a good starting point and the logs will point you in the right direction.

Thanks.

[asker]

good catch. I pushed a change in config_upgrade.py to fix this indiscriminate change. If you have a copy of the old config, just run

Code: Select all

python ./hook/config_upgrade.py -c ./old.ini -o new.ini

My guess about duplicate entries is that will only happen if you previously added those attributes on your own.

Let me know what you see.

[Magic919]

That's cleaned it up, cheers.

I think the duplications must have been me running the install twice. I do this as my zm install uses /usr/local/bin (if I don't change install.sh). Would be very handy if it read and matched the path from zm.conf.

Thanks for all your work on this.

[asker]

That's cleaned it up, cheers.

I think the duplications must have been me running the install twice. I do this as my zm install uses /usr/local/bin (if I don't change install.sh). Would be very handy if it read and matched the path from zm.conf.

Thanks for all your work on this.

Ok good. If you run the install twice (i.e. migrate once and install using the migrated config), the 2nd time it should tell you "nothing to migrate" (I hope).

[Magic919]

Try this

zmeventnotification/hook/config_upgrade.py -c zmeventnotification/hook/objectconfig.ini -o test.ini

I think I must have got the new configs, but no version number and that leads to duplicates when I try it -

cpu_max_processes=3
cpu_max_lock_wait=120

cpu_max_processes=3
cpu_max_lock_wait=120

face_detection_framework=dlib
face_recognition_framework=dlib

face_detection_framework=dlib
face_recognition_framework=dlib

[asker]

That's odd. It should always add a "version=" element after updating, if it doesn't exist.
Could you email me your original ini file before upgrade? pliablepixels at gmail.

[Magic919]

I don’t think it’s anything to do with my config. I think it did the upgrade, backed up my ini file and wrote a new one, but with no version. Then it ran the config upgrade on that.

Ideally there shouldn’t be any copies of the new version config that don’t have a version line, but that one I previously referenced is such a file.

[asker]

When it upgrades a pre config file it should add a version= line in [general]. If it did not, there would be no way for it to upgrade to the next version. When I upgrade my old config, I see version in the migrated file.

[Magic919]

I've just run this upgrade on one of my spare servers (unconfigured zme) and it creates migrated-objectconfig.ini in the directory it's run from and that has the duplicates.

[asker]

1. Which version did you upgrade from
2. Did the original have version?
3. Did the migrated one have version?
4. Duplicates of which keys? Did the original have them?

[asker]

Okay, the template objectconfig.ini in master did not have a version attribute. I just updated it. That means if you download master, it should not upgrade that ini and say "nothing to upgrade" now.

[Magic919]

That's the one in the repo under hook/ presumably.

When I re-run the command on it that I did earlier in this thread

zmeventnotification/hook/config_upgrade.py -c zmeventnotification/hook/objectconfig.ini -o test.ini

I now get

Current version of objectconfig.ini is 1.0
Nothing to migrate

Perfect.

Thanks for all your effort on this and ZMNinja.

[asker]

No problem. Thanks for proactively reporting your experiences.