Page 1 of 1

Bug affecting remote_auth still present in 1.26.x

Posted: Thu Jan 02, 2014 9:07 pm
by MJN
Hi,

First off, can I just say how pleased I am that ZoneMinder lives on in the 1.26 series. As a long-time user - from since very nearly the beginning - I was getting rather concerned when we seemed to sticking on v1.25!

That said, I've only just got round to updating, however I have found a bug that has been present since at least as far back as 2009. Specifically, if AUTH_TYPE is set to remote (e.g. if using HTTP auth) then logging in results in an infinite loop. There may be other configuration factors involved to trigger the issue but toggling this one certainly reproduces it at will.

The fix is fairly straightforward - here it is - and requires only a small ordering change to index.php.

If there's a better way to report a bug please do let me know.

Re: Bug affecting remote_auth still present in 1.26.x

Posted: Fri Jan 03, 2014 11:34 pm
by iconnor
I've reviewed the fix... looks ok to me.

I have applied it to master and it will be included in 1.26.6

Generally either here or on github is the place to report bugs... github is better generally.

Re: Bug affecting remote_auth still present in 1.26.x

Posted: Sat Jan 04, 2014 9:26 am
by MJN
Thanks Isaac, and indeed thanks for your continued contribution to this project.

Incidentally, I stumbled across your ZoneMinder PPA and I see it is intended for Ubuntu but do you know if it would also work with Debian (7/Wheezy)?

Re: Bug affecting remote_auth still present in 1.26.x

Posted: Sat Jan 04, 2014 6:56 pm
by PacoLM
Yes, please, add Debian Wheezy for your excellent work!

Re: Bug affecting remote_auth still present in 1.26.x

Posted: Sat Feb 15, 2014 1:13 am
by knight-of-ni
FYI, this fix has been incorporated into the source tree and will be included in the 1.27 release, which is currently in testing.

https://github.com/ZoneMinder/ZoneMinder/issues/296