Bug with 'in set' filter matching and execution of commands

Forum for questions and support relating to the 1.24.x releases only.
Post Reply
User avatar
MJN
Posts: 238
Joined: Wed Jan 17, 2007 10:29 am
Location: Wiltshire, UK
Contact:

Bug with 'in set' filter matching and execution of commands

Post by MJN » Wed Aug 24, 2011 8:43 pm

Hi all,

I first noticed this in v1.22.3 but for years now I've made do with a workaround and totally forgot about submitting it as a bug report. I could do with it working now so figured the least I could do was help diagnose it!

The issue is that when defining a filter using the 'in set' match criteria e.g. Monitor Name in set Conservatory,Lounge then it should match all those events where the monitor name is either Conservatory or Lounge.

This works correctly if you Submit the filter i.e. the events window appears with all the events where the monitor name matches (and where other filter criteria, if present, are also satisfied). However, if you Execute the filter - and an action such as Upload all matches is set then whilst the events window appears with the appropriate matches it does not go on to upload the events (or execute any other specified action).

If you restrict the in set criteria to only, say, Conservatory then the events are indeed uploaded. It is multi-item sets that fail.

I am confident that the cause of the problem is hinted at by the zmfilter logging output (this is from v1.22.3 in case that matters):

Code: Select all

08/24/11 20:24:41.275220 zmfilter[11245].DBG [SQL:select E.Id,E.MonitorId,M.Name as MonitorName,M.DefaultRate,M.DefaultScale,E.Name,E.Cause,E.Notes,E.StartTime,unix_timestamp(E.StartTime) as Time,E.Length,E.Frames,E.AlarmFrames,E.TotScore,E.AvgScore,E.MaxScore,E.Archived,E.Videoed,E.Uploaded,E.Emailed,E.Messaged,E.Executed from Events as E inner join Monitors as M on M.Id = E.MonitorId where not isnull(E.EndTime) and ( E.Length >= 20 and M.Name in ('Conservatory,Lounge') and E.Archived = 0 ) and ( E.Uploaded = 0 ) order by E.Id asc]
(Note that in this example filter criteria is unarchived events greater than 20s that are either from monitor name Conservatory or Lounge)

The key bit is M.Name in ('Conservatory,Lounge') which I believe should actually read M.Name in ('Conservatory','Lounge') in MySQL syntax i.e. each item in the set requires single quotes around it.

To demonstrate this within MySQL using a simple 'in set' query, firstly using ('Conservatory,Lounge'):

Code: Select all

mysql> SELECT * FROM Monitors WHERE Name IN ('Conservatory,Lounge');
Empty set (0.00 sec)
But the same query again using the syntax ('Conservatory','Lounge'):

Code: Select all

mysql> SELECT * FROM Monitors WHERE Name IN ('Conservatory','Lounge');
+----+--------------+--------+----------+---------+----------------+----------+------------+---------+--------+----------+--------+---------------+------+---------+--------------------------------------------------+-------+--------+---------+-------------+------------+----------+-----+--------+-------------+---------------------------+--------+--------+------------------+-------------+---------------+----------------+--------------------+-----------------+---------------+-----------+--------+-------------+-------------------+--------------+--------------+-----------+---------------+----------------+-----------------+-------------+------------+----------------+-------------+-------------+-------------+--------------+-------------------+-----------+----------+
| Id | Name         | Type   | Function | Enabled | LinkedMonitors | Triggers | Device     | Channel | Format | Protocol | Method | Host          | Port | SubPath | Path                                             | Width | Height | Palette | Orientation | Brightness | Contrast | Hue | Colour | EventPrefix | LabelFormat               | LabelX | LabelY | ImageBufferCount | WarmupCount | PreEventCount | PostEventCount | StreamReplayBuffer | AlarmFrameCount | SectionLength | FrameSkip | MaxFPS | AlarmMaxFPS | FPSReportInterval | RefBlendPerc | Controllable | ControlId | ControlDevice | ControlAddress | AutoStopTimeout | TrackMotion | TrackDelay | ReturnLocation | ReturnDelay | DefaultView | DefaultRate | DefaultScale | SignalCheckColour | WebColour | Sequence |
+----+--------------+--------+----------+---------+----------------+----------+------------+---------+--------+----------+--------+---------------+------+---------+--------------------------------------------------+-------+--------+---------+-------------+------------+----------+-----+--------+-------------+---------------------------+--------+--------+------------------+-------------+---------------+----------------+--------------------+-----------------+---------------+-----------+--------+-------------+-------------------+--------------+--------------+-----------+---------------+----------------+-----------------+-------------+------------+----------------+-------------+-------------+-------------+--------------+-------------------+-----------+----------+
|  1 | Conservatory | Remote | Modect   |       1 |                |          | /dev/video |       0 |      0 | http     | simple | 192.168.1.201 | 80   |         | nphmotionJpeg?Resolution=320x240&Quality=Clarity |   320 |    240 |       3 | 0           |         -1 |       -1 |  -1 |     -1 | Event-      | %N - %y/%m/%d %H:%M:%S %T |      0 |      0 |               40 |          25 |            10 |             10 |               1000 |               1 |           600 |         0 |   0.00 |        0.00 |              1000 |            7 |            0 |         0 | NULL          | NULL           |            NULL |           0 |          0 |             -1 |           0 | Events      |         100 |          100 | #0100BE           | yellow    |        1 |
|  2 | Lounge       | Remote | Modect   |       1 |                |          | /dev/video |       0 |      0 | http     | simple | 192.168.1.202 | 80   |         | nphmotionJpeg?Resolution=320x240&Quality=Clarity |   320 |    240 |       3 | 0           |         -1 |       -1 |  -1 |     -1 | Event-      | %N - %y/%m/%d %H:%M:%S    |      0 |      0 |               40 |          25 |            10 |             10 |               1000 |               1 |           600 |         0 |   4.00 |        4.00 |              1000 |            7 |            0 |         0 | NULL          | NULL           |            NULL |           0 |          0 |             -1 |           0 | Events      |         100 |          100 | #0100BE           | red       |        2 |
+----+--------------+--------+----------+---------+----------------+----------+------------+---------+--------+----------+--------+---------------+------+---------+--------------------------------------------------+-------+--------+---------+-------------+------------+----------+-----+--------+-------------+---------------------------+--------+--------+------------------+-------------+---------------+----------------+--------------------+-----------------+---------------+-----------+--------+-------------+-------------------+--------------+--------------+-----------+---------------+----------------+-----------------+-------------+------------+----------------+-------------+-------------+-------------+--------------+-------------------+-----------+----------+
2 rows in set (0.00 sec)
Apologies for just highlighting the bug and not fixing the code - my MySQL knowledge is all Google-based and was non-existent until a few hours ago, and my programming knowledge is even worse! :oops:

Regards,

Mathew
Last edited by MJN on Thu Aug 25, 2011 4:06 pm, edited 2 times in total.

User avatar
zoneminder
Site Admin
Posts: 5220
Joined: Wed Jul 09, 2003 2:07 pm
Location: Bristol, UK
Contact:

Re: Bug with 'in set' filter matching and execution of comma

Post by zoneminder » Thu Aug 25, 2011 3:51 pm

Thanks for reporting this. I will look into it.
Phil

User avatar
zoneminder
Site Admin
Posts: 5220
Joined: Wed Jul 09, 2003 2:07 pm
Location: Bristol, UK
Contact:

Re: Bug with 'in set' filter matching and execution of comma

Post by zoneminder » Thu Aug 25, 2011 9:26 pm

Should be fixed in 1.25.0 as of tomorrow.
Phil

User avatar
MJN
Posts: 238
Joined: Wed Jan 17, 2007 10:29 am
Location: Wiltshire, UK
Contact:

Re: Bug with 'in set' filter matching and execution of comma

Post by MJN » Fri Aug 26, 2011 8:49 am

That's excellent - thank you Phil. Time for me to give 1.25.0 a try!

Mathew

P.S. Next time I find a bug I won't wait years before reporting it!

Post Reply

Who is online

Users browsing this forum: No registered users and 6 guests