View Event & delete Event broken after last update

Previous development branch now released as 1.36
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

View Event & delete Event broken after last update

Post by tomcat84 »

Hi, after I updated to 1.35.10~20201015172252-bionic I cant view recorded events any more.
If I click on them I just get HTTP Error 500.
Viewing/deleting the Events with zmninja-pro is still working.
Sapozhnik
Posts: 8
Joined: Thu Oct 15, 2020 9:46 am

Re: View Event & delete Event broken after last update

Post by Sapozhnik »

I also don't see anything but don't get 500 error
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

Re: View Event & delete Event broken after last update

Post by tomcat84 »

In Firefox you get empty screen in Opera HTTP Error 500
User avatar
knight-of-ni
Posts: 2404
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: View Event & delete Event broken after last update

Post by knight-of-ni »

HTTP 500 is a web server error, so check your web server logs.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

Re: View Event & delete Event broken after last update

Post by tomcat84 »

Thats what I see in the Apache2 access.log

Code: Select all

10.0.0.1 - - [16/Oct/2020:21:25:47 +0200] "GET /zm/index.php?view=event&eid=1641&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Battr%5D=MonitorId&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bop%5D=IN&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bval%5D=1%2C7%2C2%2C3%2C4%2C5%2C6&sort_field=Id&sort_asc=1&page=1 HTTP/1.1" 500 295 "http://10.0.0.2/zm/index.php?view=events&page=1&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Battr%5D=MonitorId&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bop%5D=IN&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bval%5D=1%2C7%2C2%2C3%2C4%2C5%2C6" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 Safari/537.36 OPR/71.0.3770.271"
dougmccrary
Posts: 1210
Joined: Sat Aug 31, 2019 7:35 am
Location: San Diego

Re: View Event & delete Event broken after last update

Post by dougmccrary »

Odd. Maybe I'm doing something different, but it seems OK on 1.35.10~20201015172252-focal on FireFox.
Sapozhnik
Posts: 8
Joined: Thu Oct 15, 2020 9:46 am

Re: View Event & delete Event broken after last update

Post by Sapozhnik »

Sapozhnik wrote: Fri Oct 16, 2020 11:41 am I also don't see anything but don't get 500 error
I updated today ZM and problem was solved.
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

Re: View Event & delete Event broken after last update

Post by tomcat84 »

I updated today to 1.35.10~20201016145938-bionic.
But the problem still exist for me
dougmccrary
Posts: 1210
Joined: Sat Aug 31, 2019 7:35 am
Location: San Diego

Re: View Event & delete Event broken after last update

Post by dougmccrary »

Yes. Really odd.

Here, it works OK on focal,
but as you say on bionic.

BTW, I thought the timeline was fixed in the previous focal, but seems jumpy again these last two.
fish2222
Posts: 34
Joined: Sun Apr 07, 2019 6:20 pm

Re: View Event & delete Event broken after last update

Post by fish2222 »

I just updated today too and get the 500 error now also in Chrome. White screen in Firefox. Was hoping for a fix to the other issue I had but now I can't even view recordings.
User avatar
knight-of-ni
Posts: 2404
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: View Event & delete Event broken after last update

Post by knight-of-ni »

Working just fine here.

If you want to help, then post your Apache error log (not access log), showing the HTTP 500 error message.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

Re: View Event & delete Event broken after last update

Post by tomcat84 »

ok thats what i find in the error.log

Code: Select all

[Mon Oct 19 03:07:39.801500 2020] [php7:emerg] [pid 19514] [client 10.0.0.1:58113] PHP Parse error:  syntax error, unexpected ')' in /usr/share/zoneminder/www/skins/classic/views/event.php on line 219, referer: http://10.0.0.2/zm/index.php?view=events&page=1&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Battr%5D=StartDateTime&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bop%5D=%3E%3D&filter%5BQuery%5D%5Bterms%5D%5B0%5D%5Bval%5D=-1+day&filter%5BQuery%5D%5Bterms%5D%5B1%5D%5Bcnj%5D=and&filter%5BQuery%5D%5Bterms%5D%5B1%5D%5Battr%5D=MonitorId&filter%5BQuery%5D%5Bterms%5D%5B1%5D%5Bop%5D=IN&filter%5BQuery%5D%5Bterms%5D%5B1%5D%5Bval%5D=1%2C7%2C2%2C3%2C4%2C5%2C6
User avatar
knight-of-ni
Posts: 2404
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: View Event & delete Event broken after last update

Post by knight-of-ni »

Thank you. That's was extremely helpful.

Looks like this is what caused the issue:
https://github.com/ZoneMinder/zoneminde ... e9c5c39b13

I'll let Isaac know.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/
User avatar
knight-of-ni
Posts: 2404
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: View Event & delete Event broken after last update

Post by knight-of-ni »

My knee-jerk reaction to that error message is to remove the trailing comma on line 218 in event.php:

from:

Code: Select all

function($r){return $r >= 0 ? true : false;},
to:

Code: Select all

function($r){return $r >= 0 ? true : false;}
I might be wrong, but it can't hurt to try it.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/
tomcat84
Posts: 39
Joined: Fri Jul 03, 2020 11:24 pm

Re: View Event & delete Event broken after last update

Post by tomcat84 »

Thanks that fix worked.
About the event delete. After I deleted all Events it seams to work again. Bevore I did this I was not able to delete single checked events in the list. Strange...I will keep an Eye on this.
Locked