RFE: Montage Review

Forum for questions and support relating to the 1.30.x releases only.
Locked
Baylink
Posts: 338
Joined: Sun Jun 19, 2005 3:19 am

RFE: Montage Review

Post by Baylink »

There are a couple enhancements I'd like to put into Montage Review. Does this code have a current specialist maintainer?

1) The timestamps are unreadably small in chrome on multiple platforms; they're fine in Firefox.

2) When switching "modes" (Live, 8-hr, 1hr, etc) on Mac, the browser window is resized (down from maximized); this doesn't happen in Windows browsers.

3) In Modect mode, it's only possible to resize a pane if it has active video; the controls aren't shown otherwise.

4) Monitors of cameras in modect mode should be labeled with the monitor name when there's no video in them. ("YPAB203W was idle")

5) There's no pause mode (combined with "can I change monitor filters (while I'm in pause mode)")

and a much bigger hill to climb:

5) It would be nice if there was a checkbox that said "when you run off the last simultaneous event in play mode, jump to the beginning of the next event". This one will require some extra smarts as one of my monitors is a weather radar JPG that changes at 6fpm, and I'll need to ignore that one somehow.

I'm both happy and inclined -- and possibly even competent -- to put time into these, but I'd like to make sure I'm not working at cross purposes with someone's roadmap, and possibly get a few pointers on where I should be looking in the codebase. Happy to contribute back, but as bad a reputation as "building the whole package from scratch" has, I'm not sure I am up to building a complete dev box to do formal pull requests from. No doubt if someone thinks a given mod is useful enough, they can help me stream it into the dev flow.

Suggestions?
User avatar
knight-of-ni
Posts: 2404
Joined: Thu Oct 18, 2007 1:55 pm
Location: Shiloh, IL

Re: RFE: Montage Review

Post by knight-of-ni »

One could say, getting more people to contribute to the source code, is on our roadmap. There is just far too much work to do to keep up with.

The original author of this feature uses ZoneMinder but is no longer contributing to the project. That's not entirely unusual, but that does leave a vacuum for someone else to fill. I think iconnor had some additional plans for montage review, but I doubt he would object if someone wanted to work on that part of zoneminder. You can always ask around in our irc channel. That is where all the day-to-day conversation happens.

The core of Montage Review is here:
https://github.com/ZoneMinder/ZoneMinde ... review.php

Look in the "js" subfolder for supporting javascript functions, montagereview.js, and php function calls come from functions.php.

Since any work would consist of java & php scripting, there is no need to rebuild zoneminder. Just directly edit the files on a running system. If you break something and can't recover, reinstall the zoneminder package to set it all back.

When satisfied, use github to pull down the source code, copy your changes to a new branch, and then push it to your fork on github.com. Github.com will detect this and ask you if you want to generate a pull request.
Visit my blog for ZoneMinder related projects using the Raspberry Pi, Orange Pi, Odroid, and the ESP8266
All of these can be found at https://zoneminder.blogspot.com/
Baylink
Posts: 338
Joined: Sun Jun 19, 2005 3:19 am

Re: RFE: Montage Review

Post by Baylink »

Gotcha. Maybe iconnor will chime in too; I know he's been pretty active.

Thanks for the pointer.

[ looks at code ]


Ahhhhh... comments.... :-)
Last edited by Baylink on Sat Sep 16, 2017 2:05 am, edited 1 time in total.
Baylink
Posts: 338
Joined: Sun Jun 19, 2005 3:19 am

Re: RFE: Montage Review

Post by Baylink »

I assume I don't want to ask about /ZoneMinder/ZoneMinder/blob/ :-)
Baylink
Posts: 338
Joined: Sun Jun 19, 2005 3:19 am

Re: RFE: Montage Review

Post by Baylink »

FWIW, most of this stuff happened in the last 2 years, except 4 (which I think has been handled a different way) and 6... which would still be nice; it's basically global-gapless-playback. I may (or may not) have time this fall to stick my head into that issue. :-}
Locked